Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[VEN-2882] Multichain Governance on Base Sepolia and Mainnet #433

Merged
merged 19 commits into from
Dec 18, 2024
Merged

[VEN-2882] Multichain Governance on Base Sepolia and Mainnet #433

merged 19 commits into from
Dec 18, 2024

Conversation

web3rover
Copy link
Contributor

Description

Resolves VEN

@web3rover web3rover changed the base branch from main to feat/ven-2880 November 27, 2024 15:57
@web3rover web3rover self-assigned this Nov 27, 2024
@web3rover web3rover marked this pull request as ready for review November 29, 2024 10:04
@web3rover web3rover requested review from chechu and GitGuru7 November 29, 2024 10:04
@web3rover @GitGuru7
fix: fixed description
3d96b4c 
Co-authored-by: GitGuru7 <[email protected]>
chechu
chechu reviewed Dec 4, 2024
View reviewed changes
vips/vip-384/bsctestnet.ts Outdated Show resolved Hide resolved
@web3rover web3rover requested review from chechu and GitGuru7 December 4, 2024 18:16
chechu
chechu reviewed Dec 5, 2024
View reviewed changes
Copy link
Member

@chechu chechu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testnet commands lgtm

@web3rover
Copy link
Contributor Author

Base Sepolia Multisig:https://sepolia.basescan.org/tx/0xfe73e8d2b27b7a3515f36475b913cc68b6c9d3c33d4b6418fdfd18a9f70aa769

@web3rover web3rover changed the title [VEN-2882] Multichain Governance on Base Sepolia [VEN-2882] Multichain Governance on Base Sepolia and Mainnet Dec 12, 2024
@chechu
Copy link
Member

chechu commented Dec 16, 2024

This VIP should add commands to refund the provider of the bootstrap liquidity for Base mainnet:

  • 5,000 USDC (TX) - to be refunded with 5,000 USDC from the Venus Treasury
  • 2 WETH (TX) - to be refunded with 2 ETH from the Venus Treasury
  • 0.05 cbBTC (TX) - to be refunded with 0.05 BTCB from the Venus Treasury

Destination address: TBD

@GitGuru7
Copy link
Contributor

Mainnet Multichain VIP LGTM

chechu
chechu reviewed Dec 16, 2024
View reviewed changes
Copy link
Member

@chechu chechu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Omnichain Governance commands, including the pre-loaded commands in the ACMCommandsAggregator, lgtm

kkirka
kkirka approved these changes Dec 16, 2024
View reviewed changes
Copy link
Contributor

@kkirka kkirka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commands and addresses LGTM. I also checked the permissions and they make sense.

@chechu
Copy link
Member

chechu commented Dec 18, 2024

https://app.venus.io/#/governance/proposal/408?chainId=56

@chechu chechu merged commit d758ce5 into feat/ven-2880 Dec 18, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chechu chechu chechu left review comments

@kkirka kkirka kkirka approved these changes

@GitGuru7 GitGuru7 Awaiting requested review from GitGuru7

Assignees

@web3rover web3rover

Labels
base mainnet base sepolia
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@web3rover @chechu @GitGuru7 @kkirka